Quiz sequencing questions use wrong response pattern format

[garemoko]

Description
Quiz sequencing questions use wrong response pattern format

Version
v3.18.3

Steps to reproduce the bug
Answer a quiz containing a sequencing question

Expected behaviour
The response format should follow the example in the xapi spec. The object.definition.correctResponsesPattern and object.definition.choices properties should also be populated. The http://learninglocker.net/xapi/cmi/sequencing/response extension should not be used.

See https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#sequencing

Actual behaviour

"result": {
    "success": true,
    "completion": true,
    "response": "{9} {16}",
    "extensions": {
      "http://learninglocker.net/xapi/cmi/sequencing/response": [
        "9",
        "16"
      ]
    }
  }

[ryasmi]

Yeah we were aware of the choices array, however, it's not clear whether the choices array should contain all of the available choices or just the selected choices. Storing all of the available choices is a bit overkill and not massively useful. This is how we've seen it used in some cases, hence we started using the key above to differentiate and store the selected choices which we think are more useful from our experience.

[garemoko]

The activity definition is specific to the question and can't be different when different people answer the question so it will always include what all the options are. The result.response contains just the selected responses.

Knowing what all the things to be sequenced are and how people sequenced them is important for visualizations showing how people ordered the items in sequence.

[ryasmi]

Ahhh apologies I thought this was a multiple choice not a sequencing question for some reason. Yeah agreed that is useful info. So as part of this issue we need to add choices array to the object definition along with the correctResponsesPattern (in your example it would potentially be 9[,]16). Then also change the result response to match that format.

[ryasmi]

I don't think the http://learninglocker.net/xapi/cmi/sequencing/response extension needs to be removed, having that stored in an array instead of a string improves the performance of reports.

[garemoko]

Ok. I left that extension in for the PR.

[HT2Bot]

🎉 This issue has been resolved in version 4.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀