Don't send no data to the LRS in the event JSON encode fails. #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryasmi
approved these changes
Dec 21, 2018
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
garemoko
added a commit
to garemoko/moodle-logstore_xapi
that referenced
this pull request
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we want to do more careful checking of the data before sending it, we should consider leaning on TinCanPHP.
Please squash when merging.
Related Issues
PR Type
Fix