fix: Avoids sending invalid JSON to the LRS. (#364)

xAPI-vle · Dec 21, 2018 · 29ae19b · 29ae19b
1 parent ca9a506
commit 29ae19b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/loader/lrs.php b/src/loader/lrs.php
@@ -29,6 +29,10 @@ function load(array $config, array $events) {
         $auth = base64_encode($username.':'.$password);
         $postdata = json_encode($statements);
 
+        if ($postdata === false) {
+            throw new \Exception('JSON encode error: '.json_last_error_msg());
+        }
+
         $request = curl_init();
         curl_setopt($request, CURLOPT_URL, $url);
         curl_setopt($request, CURLOPT_POSTFIELDS, $postdata);

diff --git a/src/loader/moodle_curl_lrs.php b/src/loader/moodle_curl_lrs.php
@@ -35,6 +35,10 @@ function load(array $config, array $events) {
         $auth = base64_encode($username.':'.$password);
         $postdata = json_encode($statements);
 
+        if ($postdata === false) {
+            throw new \Exception('JSON encode error: '.json_last_error_msg());
+        }
+
         $request = new \curl();
         $responsetext = $request->post($url, $postdata, [
             'CURLOPT_HTTPHEADER' => [