Fix bug where translations missing errors shown #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Rails is configured with `config.i18n.fallbacks = true`[0] the behaviour of `I18n.exists?` is unclear[1]. It returns true when passed `nil` because fallbacks are considered. This could be fixed by specifying `fallback: false` as a keyword arg to `I18n.exists?`[2] but if we have no key there's no point in proceeding to the check stage. [0] https://guides.rubyonrails.org/v6.0.0/configuring.html#configuring-i18n [1] ruby-i18n/i18n#365 [2] ruby-i18n/i18n#482
Who thinks '%w-literals should be delimited by [ and ]'? Nobody, that's who.
Upgrade to latest govuk rubocop
|
Code Climate has analyzed commit fd37895 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Rails is configured with
config.i18n.fallbacks = truethe behaviour ofI18n.exists?is unclear. It returns true when passednilbecause fallbacks are considered.This could be fixed by specifying
fallback: falseas a keyword arg toI18n.exists?but if we have no key there's no point in proceeding to the check stage.