Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest govuk rubocop #116

Merged

Conversation

peteryates
Copy link
Member

No description provided.

Who thinks '%w-literals should be delimited by [ and ]'?

Nobody, that's who.
@codeclimate
Copy link

codeclimate bot commented Apr 30, 2020

Code Climate has analyzed commit aacf358 and detected 0 issues on this pull request.

View more on Code Climate.

@peteryates peteryates changed the base branch from master to fix-missing-translation-data-bug April 30, 2020 09:36
Copy link

@rjlynch rjlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -19,3 +19,7 @@ Style/TrailingCommaInArrayLiteral:
Enabled: false
Naming/MethodParameterName:
Enabled: false
Style/PercentLiteralDelimiters:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧠

@peteryates peteryates merged commit fd37895 into fix-missing-translation-data-bug Apr 30, 2020
@peteryates peteryates deleted the upgrade-to-latest-govuk-rubocop branch April 30, 2020 09:40
@peteryates peteryates restored the upgrade-to-latest-govuk-rubocop branch April 30, 2020 09:48
@peteryates peteryates deleted the upgrade-to-latest-govuk-rubocop branch April 30, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants