Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin docker compose version #538

Closed
wants to merge 1 commit into from
Closed

pin docker compose version #538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@ services:
env:
global:
- LATEST="2.12-2.3.0"
- DOCKER_COMPOSE_VERSION=1.23.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably indicate required version in the README / where to find this info. We should probably update info in the Dependencies section of the ReleaseProcess wiki as well.

Also, to me, it feels a little weird to pin docker-compose and not docker version. It seems that we either say this works with a specific environment and be explicit or we don't pin anything and work with "latest" (as defined by travis ci)


before_install:
- sudo rm /usr/local/bin/docker-compose
- curl -L https://github.com/docker/compose/releases/download/${DOCKER_COMPOSE_VERSION}/docker-compose-`uname -s`-`uname -m` > docker-compose
- chmod +x docker-compose
- sudo mv docker-compose /usr/local/bin

# Build recommended versions based on: http://kafka.apache.org/downloads
matrix:
Expand Down