pin docker compose version #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wurstmeister
force-pushed
the
travis-docker-compose
branch
from
95813e9 to
8fc7021
Compare
Merged
sscaling
reviewed
Oct 26, 2019
| @@ -9,6 +9,13 @@ services: | |||
| env: | |||
| global: | |||
| - LATEST="2.12-2.3.0" | |||
| - DOCKER_COMPOSE_VERSION=1.23.2 | |||
There was a problem hiding this comment.
Should probably indicate required version in the README / where to find this info. We should probably update info in the Dependencies section of the ReleaseProcess wiki as well.
Also, to me, it feels a little weird to pin docker-compose and not docker version. It seems that we either say this works with a specific environment and be explicit or we don't pin anything and work with "latest" (as defined by travis ci)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see docker/compose#6316 (comment)
fixes #537