Add support for recursive consent withdrawn updates for ONT #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add recurse keyword and recursive behaviour for collections to: has_consent_withdrawn has_consent_withdrawn_metadata has_consent_withdrawn_permissions ensure_consent_withdrawn Add an is_minknow_report function to help in managing permissions. Rename ont.update_metadata to ont.apply_metadata to distinguish it from the secondary metadata update process. Change do_*_update function names to update_* because they read better.
kjsanger
force-pushed
the
feature/recursive-consent-withdrawn
branch
from
f6d7d4e
to
ae2c34f
Compare
mksanger
reviewed
Jul 14, 2023
Co-authored-by: mksanger <73285932+mksanger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recurse keyword and recursive behaviour for collections to:
has_consent_withdrawn
has_consent_withdrawn_metadata
has_consent_withdrawn_permissions
ensure_consent_withdrawn
Add an is_minknow_report function to help in managing permissions.
Rename ont.update_metadata to ont.apply_metadata to distinguish it from the secondary metadata update process.
Change do_update function names to update because they read better.