-
Notifications
You must be signed in to change notification settings - Fork 8
Add Che API extension for Theia Plugin API #4
Conversation
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@@ -31,3 +31,7 @@ extensions: | |||
folders: | |||
- che-theia-activity-tracker | |||
checkoutTo: master | |||
- source: https://github.com/eclipse/che-theia | |||
folders: | |||
- extensions/eclipse-che-theia-plugin-ext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only need one folder ?
I thought we wanted as well extensions/eclipse-che-theia-plugin
(to avoid some wired copy of files between two modules)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't need that, as eclipse-che-theia-plugin
published on npm as @eclipse-che/plugin
and extensions/eclipse-che-theia-plugin-ext
depends on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evidolob I think it's not helping the developer workflow to not include the module
if I modify the module locally, I want to be able to test it probably without publishing it first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I will cover that flow
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage 89.09% 89.09%
=======================================
Files 10 10
Lines 330 330
Branches 23 25 +2
=======================================
Hits 294 294
Misses 36 36
Continue to review full report at Codecov.
|
…bug with empty dependencies Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Issue: eclipse-che/che#11306
Signed-off-by: Yevhen Vydolob yvydolob@redhat.com