Skip to content
This repository has been archived by the owner on Sep 2, 2019. It is now read-only.

Add Che API extension for Theia Plugin API #4

Merged
merged 3 commits into from
Jan 2, 2019
Merged

Conversation

evidolob
Copy link
Contributor

Issue: eclipse-che/che#11306
Signed-off-by: Yevhen Vydolob yvydolob@redhat.com

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@@ -31,3 +31,7 @@ extensions:
folders:
- che-theia-activity-tracker
checkoutTo: master
- source: https://github.com/eclipse/che-theia
folders:
- extensions/eclipse-che-theia-plugin-ext
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only need one folder ?
I thought we wanted as well extensions/eclipse-che-theia-plugin (to avoid some wired copy of files between two modules)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we don't need that, as eclipse-che-theia-plugin published on npm as @eclipse-che/plugin and extensions/eclipse-che-theia-plugin-ext depends on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evidolob I think it's not helping the developer workflow to not include the module
if I modify the module locally, I want to be able to test it probably without publishing it first

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will cover that flow

@codecov
Copy link

codecov bot commented Dec 11, 2018

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          10       10           
  Lines         330      330           
  Branches       23       25    +2     
=======================================
  Hits          294      294           
  Misses         36       36
Impacted Files Coverage Δ
src/extensions.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b896774...ee81d78. Read the comment docs.

…bug with empty dependencies

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@evidolob evidolob merged commit 605e06e into master Jan 2, 2019
@evidolob evidolob deleted the add-che-api-ext branch January 2, 2019 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants