Skip to content
This repository has been archived by the owner on Sep 2, 2019. It is now read-only.

Commit

Permalink
Add Che API extension for Theia Plugin API (#4)
Browse files Browse the repository at this point in the history
eclipse-che/che#11306 add Che API extension

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
  • Loading branch information
evidolob authored Jan 2, 2019
1 parent b8b309c commit 605e06e
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 3 deletions.
5 changes: 5 additions & 0 deletions src/conf/extensions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,8 @@ extensions:
folders:
- che-theia-activity-tracker
checkoutTo: master
- source: https://github.com/eclipse/che-theia
folders:
- extensions/eclipse-che-theia-plugin
- extensions/eclipse-che-theia-plugin-ext
checkoutTo: master
4 changes: 2 additions & 2 deletions src/extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,13 @@ export class Extensions {
const updatedDependencies: any = {};
const updatedDevDependencies: any = {};

const keysDependencies = Object.keys(dependencies);
const keysDependencies = dependencies ? Object.keys(dependencies) : [];
await Promise.all(keysDependencies.map(async key => {
updatedDependencies[key] = this.updateDependency(key, dependencies[key]);
}));

rawExtensionPackage['dependencies'] = updatedDependencies;
const keysDevDependencies = Object.keys(devDependencies);
const keysDevDependencies = dependencies ? Object.keys(devDependencies) : [];
await Promise.all(keysDevDependencies.map(async key => {
updatedDevDependencies[key] = this.updateDependency(key, devDependencies[key]);
}));
Expand Down
11 changes: 11 additions & 0 deletions tests/extensions/extension-empty/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "@some/plugin",
"version": "0.0.1",
"license": "EPL-2.0",
"types": "./src/foo.d.ts",
"files": [
"src"
],
"dependencies": {},
"devDependencies": {}
}
7 changes: 6 additions & 1 deletion tests/extensions/extensions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*/

/// <reference path="index.d.ts"/>
import { Extensions } from "../../src/extensions";
import { Extensions, IExtension } from "../../src/extensions";
import * as tmp from "tmp";
import * as fs from "fs-extra";
import * as path from "path";
Expand Down Expand Up @@ -132,4 +132,9 @@ describe("Test Extensions", () => {

});

test('extension with empty dependencies', async () => {
const extensions = new Extensions(assemblyExamplePath, packagesFolderTmp, cheTheiaFolderTmp, assemblyFolderTmp, THEIA_DUMMY_VERSION);
await extensions.updateDependencies({ symbolicLinks: [path.resolve(rootFolder, "tests/extensions/extension-empty")] } as IExtension);
});

});

0 comments on commit 605e06e

Please sign in to comment.