Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Dev -> Staging #177

Closed
wants to merge 3 commits into from
Closed

Merge Dev -> Staging #177

wants to merge 3 commits into from

Conversation

gtempus
Copy link
Contributor

@gtempus gtempus commented Nov 21, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

Merge PR #172 and #176

Does this introduce a breaking change?

  • Yes
  • No

dmannarino and others added 3 commits November 7, 2024 13:17
Bump dependencies for security and starlette changes
* 🐛 fix: Only replace implementation with `dynamic`

Supports FLAG-1126

* ✅ test: add initial pytest suite

* 🎨 refactor: create more declarative methods and tests

* 📝 docs: add docstring to handler

* 📝 docs: add implementation note regarding relative URLs
@solomon-negusse
Copy link
Member

@gtempus: We were thinking of not merging the dependency upgrades in dev to staging to minimize risk of breaking DIST alerts work. Could you open a hotfix PR to production for the redirect fix?

@gtempus gtempus marked this pull request as draft November 21, 2024 19:03
@gtempus
Copy link
Contributor Author

gtempus commented Nov 21, 2024

I thought that might be the case. Thank you for the info, @solomon-negusse!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.85%. Comparing base (efab786) to head (8d79ee7).
Report is 13 commits behind head on staging.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           staging     #177   +/-   ##
========================================
  Coverage    79.85%   79.85%           
========================================
  Files           61       61           
  Lines         2050     2050           
========================================
  Hits          1637     1637           
  Misses         413      413           
Flag Coverage Δ
unittests 79.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gtempus
Copy link
Contributor Author

gtempus commented Nov 27, 2024

Closing this in favor of cherry picking just the bugfix. See #176

@gtempus gtempus closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants