🐛 Fix: implementation replacement on redirect #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtempus
requested review from
solomon-negusse,
danscales,
dmannarino and
manukala6
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #176 +/- ##
=======================================
Coverage 79.85% 79.85%
=======================================
Files 61 61
Lines 2050 2050
=======================================
Hits 1637 1637
Misses 413 413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
gtempus
force-pushed
the
bug-implementation-replacement-on-redirect
branch
from
82042cd to
27ef81a
Compare
danscales
reviewed
Nov 18, 2024
...orm/modules/content_delivery_network/lambda_functions/redirect_s3_404/src/lambda_function.py
Show resolved
Hide resolved
gtempus
force-pushed
the
bug-implementation-replacement-on-redirect
branch
from
06b1922 to
590705e
Compare
danscales
approved these changes
Nov 19, 2024
...orm/modules/content_delivery_network/lambda_functions/redirect_s3_404/src/lambda_function.py
Show resolved
Hide resolved
manukala6
approved these changes
Nov 19, 2024
gtempus
added a commit
that referenced
this pull request
Nov 21, 2024
* 🐛 fix: Only replace implementation with `dynamic` Supports FLAG-1126 * ✅ test: add initial pytest suite * 🎨 refactor: create more declarative methods and tests * 📝 docs: add docstring to handler * 📝 docs: add implementation note regarding relative URLs (cherry picked from commit 8d79ee7)
gtempus
added a commit
that referenced
this pull request
Nov 21, 2024
* 🐛 fix: Only replace implementation with `dynamic` Supports FLAG-1126 * ✅ test: add initial pytest suite * 🎨 refactor: create more declarative methods and tests * 📝 docs: add docstring to handler * 📝 docs: add implementation note regarding relative URLs (cherry picked from commit 8d79ee7)
gtempus
added a commit
that referenced
this pull request
Nov 26, 2024
* 🐛 fix: Only replace implementation with `dynamic` Supports FLAG-1126 * ✅ test: add initial pytest suite * 🎨 refactor: create more declarative methods and tests * 📝 docs: add docstring to handler * 📝 docs: add implementation note regarding relative URLs (cherry picked from commit 8d79ee7) (cherry picked from commit bc6a6c7)
gtempus
added a commit
that referenced
this pull request
Nov 26, 2024
* 🐛 fix: Only replace implementation with `dynamic` Supports FLAG-1126 * ✅ test: add initial pytest suite * 🎨 refactor: create more declarative methods and tests * 📝 docs: add docstring to handler * 📝 docs: add implementation note regarding relative URLs (cherry picked from commit 8d79ee7) (cherry picked from commit bc6a6c7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
The string literal
dynamicreplaces any part of the URL path that matches theimplementationpart of the URL.For example:
/sbtn_
natural_forests_map/v202310/natural_forest/10/20/30.pngwas resulting in the following incorrect redirect URL:
/sbtn_
dynamics_map/v202310/dynamic/10/20/30.png?implementation=natural_forestWhat is the new behavior?
Now, the URL:
/sbtn_natural_forests_map/v202310/natural_forest/10/20/30.pngIs correctly transformed into:
/sbtn_natural_forests_map/v202310/dynamic/10/20/30.png?implementation=natural_forestDoes this introduce a breaking change?