-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify config sub-section menu items; See: websharks/comment-mail#187 #212
Conversation
NOTE: This is a work-in-progress. Still working on the following:
|
@kristineds That looks awesome! Can we get a PR for the Pro version as well? :-) |
$heading .= ' </div>'."\n"; | ||
|
||
$heading .= ' <div class="pmp-version">'."\n"; | ||
$heading .= ' <span> '.sprintf(__('%1$s™ Pro v%2$s (<a href="https://comment-mail.com/changelog/">changelog</a>)', 'comment-mail'), esc_html($this->plugin->name), esc_html($this->plugin->version)).'</span>'."\n"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristineds This shouldn't say "Pro" for the Lite version...
Changing this to |
@kristineds Thank you! I reviewed this and the Pro PR; here's some feedback: The group of links with I'd like all of those links and the Restore button to line up with on the right side. I also suggest increasing the I'm making a similar request for the Pro version; I'll post screenshots on that PR. |
@kristineds I tested this PR and the alignment looks great now! Thank you. |
Simplify config sub-section menu items;
See: #187