-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show installed version number on plugin options panels #187
Comments
@raamdev Do you want to add it in the same way as what was done with ZC?
On a different note, I feel like all those options below the Comment Mail logo feels a bit crowded, imo. :) What you have with ZC looks more organized and clean (i.e. the options for Pro Upgrade, Newsletter, Preview Pro features are placed on the upper right side). cc @jaswsinc |
Yes, that sounds great!
I totally agree. That has been bugging me for awhile. It feels like the least-polished part of Comment Mail that you use on a regular basis (and the first time you use it, those options are not obvious at all--we improved this in #112). What I'd really love to see in place of what we have now is a tabbed system, something that looks like this but also includes the icons that we have now: Many plugins use a similar tabbed style, StCR and WP Super Cache being the two that immediately come to mind, so users are likely to already be familiar with it. @jaswsinc Any objection to implementing a tabbed-style for those options? |
@raamdev Sounds cool. I have no objections. |
After putting a bit more thought into this, my feeling now is that we don't need a tabbed system at all. In fact, we can just clean things up so that there aren't so many items there. Instead of turning those items into a tabbed system, why don't we just remove the items that really don't belong there and use something more like what we have in ZenCache: |
@jaswsinc @raamdev I was able to move the sub-section menu items but I'm having a hard time adding the version number and Pro Updater link on the PRO version. Would need your guidance on this. :) I have this so far..
$heading .= ' <div class="pmp-version">'."\n";
$heading .= ' <span> '.__('%1$s™ Pro v%2$s', $this->plugin->text_domain), esc_html($this->plugin->name), esc_html($this->plugin->version).'</span>'."\n";
$heading .= ' </div>'."\n";
if(!$this->plugin->is_pro) // Display pro updater
{
$heading .= ' <a href="'.esc_attr($this->plugin->utils_url->pro_updater_menu_page_only()).'"'.
($this->plugin->utils_env->is_pro_updater_menu_page_only() ? ' class="pmp-active"' : '').'>'.
'<i class="fa fa-magic"></i> '.__('Pro Updater', $this->plugin->text_domain).'</a>'."\n";
} |
@kristineds It looks all you're missing here is the $heading .= ' <div class="pmp-version">'."\n";
$heading .= ' <span> '.sprintf(__('%1$s™ Pro v%2$s', $this->plugin->text_domain), esc_html($this->plugin->name), esc_html($this->plugin->version)).'</span>'."\n";
$heading .= ' </div>'."\n"; See also: http://php.net/manual/en/function.sprintf.php Note that |
@kristineds This function does not exist to my knowledge.
You can use this instead, which does exist: $this->plugin->utils_env->is_menu_page(__NAMESPACE__.'_pro_updater') |
@kristineds Just checking in here. Anything not clear enough? If so just give us a shout! :-) |
Next Lite Release Changelog:
|
Next Pro Release Changelog:
|
Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details. This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#187). |
It would be nice to show the installed plugin version right inside the plugin options page along with a link to the changelog:
The text was updated successfully, but these errors were encountered: