Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpilibc] use std::atomic for ADIS classes #6217

Merged
merged 5 commits into from
Jan 16, 2024
Merged

[wpilibc] use std::atomic for ADIS classes #6217

merged 5 commits into from
Jan 16, 2024

Conversation

spacey-sooty
Copy link
Contributor

Resolves #6213

@calcmogul
Copy link
Member

You'll need to implement the user-defined move semantics like the issue said to get the build passing.

@spacey-sooty
Copy link
Contributor Author

You'll need to implement the user-defined move semantics like the issue said to get the build passing.

I know I'm working on that rn

@spacey-sooty
Copy link
Contributor Author

After creating the move ctor do I also need to overload the operator @calcmogul

@calcmogul
Copy link
Member

Yes.

@spacey-sooty spacey-sooty marked this pull request as ready for review January 14, 2024 11:17
@spacey-sooty spacey-sooty requested a review from a team as a code owner January 14, 2024 11:17
@PeterJohnson PeterJohnson merged commit 30965b2 into wpilibsuite:main Jan 16, 2024
25 checks passed
@spacey-sooty spacey-sooty deleted the adis-atomic branch June 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++ ADIS classes use volatile instead of atomic, which creates race conditions
3 participants
@spacey-sooty @calcmogul @PeterJohnson