-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default AprilTag config #5896
Conversation
apriltag/src/main/java/edu/wpi/first/apriltag/AprilTagDetector.java
Outdated
Show resolved
Hide resolved
Are these still reasonable values given the change to 36h11 tag family? |
This might still be too loose; in theory, the camera needs to be closer to the tag to detect it properly, so perhaps the pixel threshold should be increased? The issue says too strict is better than too loose. |
I doubled the minimum number of pixels required to not reject a quad; the quad now has to be a 20x20 square (or equivalent) for it to not be rejected (which is still fairly small). |
Resolves the rest of #4920 along with #5895.