Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Apriltags Docstrings and Defaults #4920

Closed
TheTripleV opened this issue Jan 8, 2023 · 0 comments · Fixed by #6847
Closed

Improve Apriltags Docstrings and Defaults #4920

TheTripleV opened this issue Jan 8, 2023 · 0 comments · Fixed by #6847
Labels
component: apriltag AprilTag library type: docs Related to documentation and information.

Comments

@TheTripleV
Copy link
Member

docstrings / API

.detect - Input image has to be grayscale
.getCorner* - Specify that idx 0 is the bottom left corner OR change the functions to getTopLeftCorner etc.

Config Defaults

minClusterPixels should be increased from 5. I think to at least 200 (0.2% of a 240p frame).
criticalAngle should be increased from 10 degrees to at least 45 degrees.

^ Or higher for both.

The defaults should be too strict and allow teams to loosen the detector, not too loose and force teams to get rid of noise.

@Starlight220 Starlight220 added the component: apriltag AprilTag library label Jan 16, 2023
@calcmogul calcmogul added the type: docs Related to documentation and information. label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: apriltag AprilTag library type: docs Related to documentation and information.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants