[wpilib] Add class to calculate robot resistance #5500
+738
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJohnson
previously approved these changes
Aug 3, 2023
|
Has this been tested on a real robot to make sure the values are reasonable? Based on the discussion on #4162 i don't think it has been. |
|
It has not. That's what killed the PR last time. |
ohowe1
reviewed
Aug 3, 2023
wpilibj/src/main/java/edu/wpi/first/wpilibj/PowerDistribution.java
Outdated
Show resolved
Hide resolved
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
1f06549
to
496e7ae
Compare
calcmogul
added
state: blocked
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
496e7ae
to
d6570dd
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
d6570dd
to
80a5e1d
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
80a5e1d
to
121df22
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
cd024f8
to
57be9db
Compare
|
Tests to run would include resistance printouts for no-load and high-load cases, as well as whether it can detect wire disconnects. |
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
57be9db
to
b213d77
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
2 times, most recently
from
360128a
to
25d0037
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
25d0037
to
75b6fc8
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
75b6fc8
to
1b7e47e
Compare
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
1b7e47e
to
80a06d7
Compare
Co-authored-by: ysthakur <45539777+ysthakur@users.noreply.github.com>
calcmogul
force-pushed
the
wpilib-add-class-to-calculate-robot-resistance
branch
from
80a06d7
to
25ef8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.