Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResistanceCalculator.java can be removed #9

Open
ysthakur opened this issue Sep 11, 2023 · 1 comment
Open

ResistanceCalculator.java can be removed #9

ysthakur opened this issue Sep 11, 2023 · 1 comment

Comments

@ysthakur
Copy link

ysthakur commented Sep 11, 2023 •
edited
Loading

You guys can probably remove ResistanceCalculator.java (and any associated code). It was only added in so that this PR could be tested (it's closed now). If you guys do have free time and want to test out the resistance calculator, there's a new PR where you can post your data. I'm sure it would be much appreciated there.

Also, great job with Voyager!
@calcmogul
Copy link

calcmogul commented Sep 16, 2023 •
edited
Loading

Indeed, testing that PR on a real control system would be greatly appreciated. That's the main blocker for merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calcmogul @ysthakur