Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update common-jvm dep for Maven BOMs #1790

Merged
merged 1 commit into from
Sep 9, 2024
Merged

build: Update common-jvm dep for Maven BOMs #1790

merged 1 commit into from
Sep 9, 2024

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Sep 4, 2024 •
edited
Loading

Closes #1794

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas
Copy link
Member Author

Depends on world-federation-of-advertisers/common-jvm#268

@SanjayVas SanjayVas force-pushed the sanjayvas-maven-bom branch 3 times, most recently from 2e28936 to 8fa07af Compare September 4, 2024 20:51
This was referenced Sep 6, 2024
Open
Closed
stevenwarejones
stevenwarejones approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

SanjayVas
SanjayVas commented Sep 9, 2024
View reviewed changes
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit c52d8eb into main Sep 9, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-maven-bom branch September 9, 2024 21:17
@SanjayVas SanjayVas mentioned this pull request Sep 18, 2024
Merged
SanjayVas added a commit that referenced this pull request Sep 23, 2024
@SanjayVas
fix: Address compile warnings on custom Truth subjects (#1818)
58eb5f2 
These were introduced when the Truth version was upgraded in #1790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenwarejones stevenwarejones stevenwarejones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use BOMs for Maven dependencies where available
3 participants
@SanjayVas @wfa-reviewable @stevenwarejones