build!: Update rules_kotlin_jvm dep for Maven BOMs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
from
4eb264e
to
554d2b6
Compare
SanjayVas
changed the title
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
3 times, most recently
from
6eacb68
to
36fe884
Compare
|
Depends on world-federation-of-advertisers/rules_kotlin_jvm#8 and #270 |
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
from
36fe884
to
1c5bba3
Compare
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
from
1c5bba3
to
ca11ec6
Compare
SanjayVas
changed the title
9 tasks
stevenwarejones
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
from
ca11ec6
to
6cacbd5
Compare
SanjayVas
force-pushed
the
sanjayvas-spanner-test
branch
from
793658c
to
8a9c2da
Compare
SanjayVas
force-pushed
the
sanjayvas-maven-bom
branch
from
6cacbd5
to
14435e6
Compare
SanjayVas
commented
Sep 6, 2024
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
SanjayVas
added a commit
that referenced
this pull request
Sep 23, 2024
These were introduced when the Truth version was upgraded in #268.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces compatibility issues with Maven version resolution.