Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to remove some in favor of automated testing #142

Merged
merged 2 commits into from
May 30, 2023
Merged

Update tests to remove some in favor of automated testing #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba8af3
Update tests to remove some in favor of automated testing
May 30, 2023
4d4fbb9
Remove Columns manual test TC011 in favor of automated testing
May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test-cases/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ Gutenberg:
- [Media-Text block](./gutenberg/media-text.md)
- [Mentions](./gutenberg/mentions.md)
- [Shortcode block](./gutenberg/shortcode.md)
- [Spacer block](./gutenberg/spacer.md)
- [Unsupported block editing](./gutenberg/unsupported-block-editing.md)
- [Verse block](./gutenberg/verse.md)
- [Video block](./gutenberg/video.md)
Expand Down
173 changes: 0 additions & 173 deletions test-cases/gutenberg/columns.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe TC011 can be removed as well, if desired. wordpress-mobile/gutenberg-mobile#5548

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll remove it 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 4d4fbb9

Original file line number Diff line number Diff line change
Expand Up @@ -2,164 +2,6 @@

--------------------------------------------------------------------------------

##### TC001

### Check if Column placeholders is visible for the unselected state

- Add a `Columns` block
- Deselect
- Expect to see placeholder for each `Column` added in `Columns`

Expected look:

Portrait | Landscape
-|-
![PlaceholderHorizontal](../resources/columns-placeholder-root-horizontal.png)|![PlaceholderStacked](../resources/columns-placeholder-root.png)


--------------------------------------------------------------------------------

##### TC002

### Max limit of Column number

- Add a `Columns` block
- Increase number of `Column`
- Expect have **no limit** with possible number of `Column` to add

--------------------------------------------------------------------------------

##### TC003

### Deep nesting is possible

- Add a `Columns` block
- Nest blocks inside multiple `Columns` blocks (at least 3 levels deep)
- Expect app do not crash

--------------------------------------------------------------------------------

##### TC004

### Appearance in vertical device position (vertical layout)

- Add a `Columns` block
- Create some nested structure adding more `Column` and nesting `Columns`
- Expect all `Column` is stacked (only 1 `Column` in row is render)
- Expect space around blocks do not bounce when changing selection (exception is the transition of the selected block connected with making space for FloatingToolbar)
- Expect no weird/unexpected extra free space around blocks
- Expect the space from screen edge to content should equals `16px`

Exception:

- If there is enough space (more than `480px`) for `Columns` then it will be render in `horizontal` layout

Expected look:
![ColumnsVertical](../resources/columns-vertical-layout.png)

- Space of `16px` left/right

--------------------------------------------------------------------------------

##### TC005

### Appearance in horizontal device position (horizontal layout)

- Rotate device to horizontal position
- Add `Columns` block
- Create some nested structure adding more `Column` and nesting `Columns`
- Expect all `Column` is distributed in row depending on available space for container:
- below `480px` then expect 1 `Column` in row to be rendered
- between `480px` and `768px` then expect 3 `Column` in row to be rendered
- more than `768px` then expect as much `Column` as possible in row to be rendered
- Expect space around blocks do not bounce when changing selection (exception is the transition of the selected block connected with making space for FloatingToolbar)
- Expect no weird/unexpected extra free space around blocks
- Expect the space around each `Column` should equals `16px`

Expected look:
![ColumnsHorizontal](../resources/columns-horizontal-layout.png)

- Space of `16px` left/right/top/bottom

--------------------------------------------------------------------------------

##### TC006

### Mover direction

- Add `Columns` block
- Create some nested structure adding more `Column` and nesting `Columns`
- Make `Column` stacked in `Columns` by rotate device to vertical position
- Select `Column`
- Expect `Mover` controls be in vertical position
- Switch `Columns` to horizontal layout by rotate device to horizontal position
- Select `Column`
- Expect `Mover` controls be in horizontal position
- Expect nested `Column` has proper `Mover` position

Expected look:
![MoverVertical](../resources/columns-mover-vertical.png)
![MoverHorizontal](../resources/columns-mover-horizontal.png)

--------------------------------------------------------------------------------

##### TC007

### Check if Column placeholder is render in nested structure

- Add a `Columns` block
- Nest some `Columns` inside one of the `Column`
- Select top-most `Columns` block in hierarchy
- Check if you are able to see `Column` placeholder of nested blocks wrapped with dashed border when the parent is selected
- Select one of the `Column`
- Expect to see it's `AppenderButton` after selecting last `Column`

Expected look:
![PlaceholderNested](../resources/columns-placeholder-nested.png)

- Post title is not dimmed
- Navigation arrows is not visible
- Only selected block title is visible in breadcrumbs

--------------------------------------------------------------------------------

##### TC008

### Unselected Column placeholder is streched to content in nested structure

- Add a `Columns` block
- Switch to `horizontal` layout
- Add some blocks inside one of the `Column`
- Select top-most `Columns` block in hierarchy
- Expect empty `Column` placeholder to be stretched accordingly
- Select `Column` with the content
- Expect empty `Column` placeholder in the same row to be stretched accordingly. Note: [known issue](https://github.com/wordpress-mobile/gutenberg-mobile/issues/4081) that the placeholder is not actually stretched vertically as expected.

Expected look:
![PlaceholderStretched](../resources/columns-placeholder-stretched.png)

- Post title is not dimmed
- Navigation arrows is not visible
- Only selected block title is visible in breadcrumbs
- Placeholder (dashed line is stretched to content)

--------------------------------------------------------------------------------

##### TC009

### Check if in DarkMode all components gets proper colors

- Add a `Columns` block
- Create nested structure
- Switch to DarkMode
- Check if all components switch it's color schema to dark

Expected look:
![DarkMode](../resources/columns-dark-mode.png)
![DarkModeEmpty](../resources/columns-dark-mode-empty.png)

--------------------------------------------------------------------------------

##### TC010

### Columns percentage mechanism - custom percentage values are rendered correctly on frontend
Expand All @@ -175,18 +17,3 @@ Expected look:
- Check the preview and expect to see that the front end reflects the column widths

--------------------------------------------------------------------------------

##### TC011

### Multiple slider in columns parent

- Add a `Columns` block
- Expect to see bottom sheet with layout picker
- Press `Cancel` button on layout picker
- Open `Columns` settings
- Play with sliders
- Expect that fill level in the preview (to the left of a slider) is changing proportionally in all columns

<img src="../resources/columns-multiple-sliders.gif" width=300 />

--------------------------------------------------------------------------------
13 changes: 0 additions & 13 deletions test-cases/gutenberg/darkmode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,19 +75,6 @@ Expected look:

--------------------------------------------------------------------------------

##### TC007

### Columns Block - Check if in DarkMode all components gets proper colors

- Add a `Columns` block
- Check if `Columns` block in Dark Mode looks like below

Expected look:
![ColumnsDarkMode](../resources/columns-dark-mode.png)
![ColumnsDarkModeEmpty](../resources/columns-dark-mode-empty.png)

--------------------------------------------------------------------------------

##### TC008

### Quote Block - Check if in DarkMode all components gets proper colors
Expand Down
44 changes: 0 additions & 44 deletions test-cases/gutenberg/gallery.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,50 +57,6 @@ Gallery block should allow uploading multiple images after the editor is closed.

--------------------------------------------------------------------------------

##### TC003

### Add caption to gallery

- Add a Gallery block
- Set a caption to your gallery

![Gallery Caption](../resources/gallery-caption-3.png)
- Add some styles to your caption:
- Bold
- Italic
- Strikethrough
- Expect all to work correctly

(Note: Underlined text is only rendered if it is set by a .com site, the Underline format button is not available in mobile.)

![Gallery Caption Styles](../resources/gallery-caption-4.png)

- Save the post
- Open it and expect to see the captions with their styles

--------------------------------------------------------------------------------

##### TC004

### Add caption to gallery images

- Add a Gallery block
- Add some images to your gallery
- Set some captions to your images by tapping on each image

![Gallery Image Caption](../resources/gallery-caption-1.png)
- Add some styles to your captions:
- Bold
- Italic
- Expect all to work correctly

![Gallery Image Caption Styles](../resources/gallery-caption-2.png)

- Save the post
- Open it and expect to see the captions with their styles

--------------------------------------------------------------------------------

##### TC005

### Choose from device (stay in editor) - Successful upload
Expand Down
13 changes: 0 additions & 13 deletions test-cases/gutenberg/spacer.md
View file
Open in desktop

This file was deleted.

Loading