Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to remove some in favor of automated testing #142

Merged
merged 2 commits into from
May 30, 2023
Merged

Update tests to remove some in favor of automated testing #142

merged 2 commits into from
May 30, 2023

Conversation

geriux
Copy link

@geriux geriux commented May 30, 2023 •
edited
Loading

This PR updates some manual tests in favor of automated testing.

@geriux geriux marked this pull request as ready for review May 30, 2023 14:55
@geriux geriux requested a review from dcalhoun May 30, 2023 14:55
dcalhoun
dcalhoun approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

Thank you! If you have time, please update the tracking spreadsheet with the latest status for these tests.

test-cases/gutenberg/columns.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe TC011 can be removed as well, if desired. wordpress-mobile/gutenberg-mobile#5548

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll remove it 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 4d4fbb9

@geriux
Copy link
Author

geriux commented May 30, 2023

🔥🔥🔥

Thank you! If you have time, please update the tracking spreadsheet with the latest status for these tests.

Will do! Thank you for reviewing! 🚀

@geriux geriux merged commit 2356f5d into trunk May 30, 2023
@geriux geriux deleted the remove-automated-tests branch May 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @dcalhoun