Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image cropped vertically #447

Closed
wants to merge 5 commits into from

Conversation

etoledom
Copy link
Contributor

Fixes #444

Gutenberg side: WordPress/gutenberg#13096

The image size implementations tries to follow closely the web implementation. I tried to share some code from ImageSize but most of it is platform specific. I made a small utils to share some math calculations.

On a future PR I plan to implement some kind of loading indicator.
cc @iamthomasbishop

image_height

To test:

  • Run the example project.
  • Scroll down to the last block.
  • Check that the image displays correctly as shown in the attached image.

@etoledom etoledom added the [Type] Bug Something isn't working label Dec 25, 2018
@etoledom etoledom added this to the Beta milestone Dec 25, 2018
@etoledom etoledom self-assigned this Dec 25, 2018
@etoledom etoledom requested a review from Tug December 25, 2018 12:38
@iamthomasbishop
Copy link
Contributor

Awesome! Thanks for fixing this @etoledom!!

@etoledom
Copy link
Contributor Author

Hey @iamthomasbishop - glad you like it :)

I'm wandering what do you think about an activity indicator when the image is loading?
This is how it looks now:

image_loading

(That is pretty much the behavior on web, but on mobile I would expect some kind of activity indicator)

@iamthomasbishop
Copy link
Contributor

I would also expect a loading indicator. Is there any chance we can utilize the same approach that we took on Aztec uploads, where you see a loader over the top of the media as it loads?

@etoledom
Copy link
Contributor Author

I created a new issue for the activity indicator task.
Let's move that conversation to: #451

@etoledom
Copy link
Contributor Author

Hey @Tug !
I updated the gutenberg reference to latest master. Everything is working in my local tests.
Please take a look before the final merge.
Thank you!

@etoledom
Copy link
Contributor Author

The gutenberg reference already was updated in develop so this PR is not needed anymore.

@etoledom etoledom closed this Jan 18, 2019
@etoledom etoledom deleted the issue/444-image-cropped-vertically branch January 28, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image block cropps image vertically.
2 participants