[Mobile] Image height #13096
Merged
[Mobile] Image height #13096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etoledom
added
Mobile Web
Tug
reviewed
Dec 26, 2018
Tug
reviewed
Dec 26, 2018
Tug
reviewed
Dec 26, 2018
|
Beside the minor comments I had, this LGTM 👍 Great work here! |
|
Thanks @Tug for the review! |
|
This looks good now 👍 |
mzorz
reviewed
Jan 2, 2019
etoledom
force-pushed
the
rnmobile/image-block-img-size
branch
from
c46abbd
to
556b29b
Compare
etoledom
force-pushed
the
rnmobile/image-block-img-size
branch
from
556b29b
to
b72c99b
Compare
etoledom
commented
Jan 3, 2019
| class ImageEdit extends Component { | ||
| constructor() { | ||
| super( ...arguments ); | ||
| this.onMediaLibraryPress = this.onMediaLibraryPress.bind( this ); |
There was a problem hiding this comment.
Hey @Tug ! I had to add this bind back since it was giving an error accessing this.props.setAttributes.
There was a problem hiding this comment.
Yep, usually onSomething methods need to be bound to this 👍
|
Thank you @Tug ! Everything should be fixed now. Ready for another look 👍 |
|
Thank you! |
youknowriad
reviewed
Jan 18, 2019
| @@ -0,0 +1,9 @@ | |||
|
|
|||
| export function calculatePreferedImageSize( image, container ) { | |||
There was a problem hiding this comment.
Would be good to add some JSDocs :)
This was referenced Jan 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [rnmobile]: Convert image-block into class * [rnmobile]: Creating mobile version of `image-size`. * [rnmobile]: Adding util to image-block to share math between image-size components. * [rnmobile]: Adding newline at the end of image-size.native.js file * [rnmobile]: Replace wrong tabs characters * [rnmobile]: Clear image size when url changes. * [rnmobile]: Fixed lint issues * [rnmobile]: Removing unnecessary binding calls * [rnmobile]: Added necessary this.onLayout.bind( this ) * [rnmobile]: Adding missing bind to `onMediaLibraryPress`.
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [rnmobile]: Convert image-block into class * [rnmobile]: Creating mobile version of `image-size`. * [rnmobile]: Adding util to image-block to share math between image-size components. * [rnmobile]: Adding newline at the end of image-size.native.js file * [rnmobile]: Replace wrong tabs characters * [rnmobile]: Clear image size when url changes. * [rnmobile]: Fixed lint issues * [rnmobile]: Removing unnecessary binding calls * [rnmobile]: Added necessary this.onLayout.bind( this ) * [rnmobile]: Adding missing bind to `onMediaLibraryPress`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes over this (very old) PR #9975 to solve the issue wordpress-mobile/gutenberg-mobile#444
The image size implementations tries to follow closely the web implementation. I tried to share some code from
ImageSizebut most of it is platform specific. I made a smallutilsto share some math calculations.On a future PR I plan to implement some kind of loading indicator.
To test:
Refer to the
gutenberg-mobilePR.