Upgrade to RN 0.64.0 #3430
Upgrade to RN 0.64.0 #3430
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Looks like commenting here to bookmark solutions from this thread: facebook/react-native#28126 |
Expecting this to fix the following error:
```
/home/circleci/project/gutenberg/node_modules/@react-native/polyfills/error-guard.js:14
type ErrorHandler = (error: mixed, isFatal: boolean) => void;
^^^^^^^^^^^^
SyntaxError: Unexpected identifier
at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/node_modules/@jest/transform/build/ScriptTransformer.js:537:17)
at Object.<anonymous> (gutenberg/node_modules/react-native/jest/setup.js:434:6)
```
| "name": "react-native-blur", | ||
| "version": "0.8.0", |
There was a problem hiding this comment.
This is strange 😕 We probably won't want this kind of downgrade. I'll check the diff of native iOS files and react-native-blur's podspec.
There was a problem hiding this comment.
This seems to be wrong in the Podspec, we'll need to fork this repo:
https://github.com/Kureev/react-native-blur/blob/v3.3.0/react-native-blur.podspec#L3
There was a problem hiding this comment.
@hypest I've created the fork and pushed the related fix: wordpress-mobile/react-native-blur#1, but I may need some help with setting up Jitpack :(
After it's set up, will push a v3.6.1-wp tag in wp-fork branch to get it used in the generated podspecs.
There was a problem hiding this comment.
Thanks for the ping Ceyhun! We had the chance to talk about this (the new fork) during a 1:1 and we said that it's fine for us to not depend on the fork for the initial merge of the RN upgrade, and wrangle it afterwards as part of cleaning up all the fork upgrade PRs.
There was a problem hiding this comment.
Just added a workaround for now in generate-podspecs.sh for react-native-blur specifically and also some warning messages to catch this and also to not modify podspecs manually.
|
|
| "homepage": "https://github.com/react-native-community/react-native-blur", | ||
| "source": { | ||
| "git": "https://github.com/react-native-community/react-native-blur.git" |
There was a problem hiding this comment.
Also no tag or commit is defined in the latest version: https://github.com/Kureev/react-native-blur/blob/v3.6.1/react-native-blur.podspec#L15, which means this would depend on main branch instead.
And even if it was defined, it's still not published on npm: https://www.npmjs.com/package/@react-native-community/blur/v/3.6.1
|
The "Publish to S3" job on 084cf3d seemed to fail due to some networking issue, most possibly. Let's just restart when all jobs conclude. |
Description
Upgrade React Native to version 0.64.0 (See RN Upgrade Helper)
Related PRs:
How has this been tested?
To test: Gutenberg Editor should work as expected.
Try to run all the manual tests.
Remaining Tasks:
rnmobile/try/upgrade-0-64branch is updated to 0.64.0-rc3 and needs to be updated to 0.64.0 stable.rnmobile/try/upgrade-0-64needs to be updated with latest gutenberg trunk which contains some larger updates for handling WPAndroid composite buildsrnmobile/try/upgrade-0-64PR submission checklist: