Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix RN0.64 upgrade WPAndroid insert link crash #3597

Closed
wants to merge 7 commits into from

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 8, 2021

Fixes #

Gutenberg PR: WordPress/gutenberg#32517
WPAndroid PR: wordpress-mobile/WordPress-Android#14802

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@hypest hypest changed the title Try to fix WPAndroid insert link crash Try to fix RN0.64 upgrade WPAndroid insert link crash Jun 8, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@hypest
Copy link
Contributor Author

hypest commented Jun 9, 2021

Tried the WPAndroid installable build built off c727eff and it doesn't crash for me when trying to add a link inside a paragraph by tapping on the link toolbar button! 🎉

@hypest
Copy link
Contributor Author

hypest commented Jun 9, 2021

Installable build still works ok (smoke testing) after all the deps updates.

At this point @ceyhun , I think we can consider merging the all the "extra PRs" into the main 0.64 upgrade PRs, let me know what you think.

@hypest
Copy link
Contributor Author

hypest commented Jun 10, 2021

Android Writing Flow checklist

Android 11, physical Pixel 2XL - using WPAndroid installable build 109148, Gutenberg hash WordPress/gutenberg@a6ce908.

General

  • TC001 - Paste formatted text copied from website => I don't see the images being pasted, but same happens on develop so, the RN upgrade doesn't introduce an issue. In fact pasting with images included works OK if copied from a site like lipsum.com
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor

SiobhyB commented Jun 10, 2021

iOS Writing Flow checklist

iOS 14.4, physical iPhone XR - using WordPress iOS installable build 50172

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@hypest
Copy link
Contributor Author

hypest commented Jun 11, 2021

The failed Check Correctness job (with a lint issue with eslint-plugin-jsdoc) is already fixed in develop.

Base automatically changed from try/upgrade-0-64 to develop June 16, 2021 18:53
@hypest
Copy link
Contributor Author

hypest commented Jun 17, 2021

Fix has been included in the main RN 0.64 upgrade PRs already and those got merged already so, closing this 🎉.

@hypest hypest closed this Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants