Fix gallery size labels

[mkevins]

Related PRs

gutenberg: WordPress/gutenberg#19800
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#1798
WordPress-Android: wordpress-mobile/WordPress-Android#11124

Description

This PR fixes the image size option labels in the gallery block settings. The image size options were added for web, but on mobile, the labels were undefined. This resulted in "blank" buttons, and in the beta build for iOS this also resulted in a crash.

This PR should fix the following issue: wordpress-mobile/gutenberg-mobile#1792

How has this been tested?

Tested on Android via WordPress-Android, and iOS via WordPress-iOS:

Steps:

• Create a gallery block with some images
• Tap the gallery
• Tap the gallery settings icon (the gear)
• Tap "Images size"

Expected result:

• The app should not crash
• The image size options should be visible in the menu

Steps:

• Tap one of the image size options (e.g. thumbnail)

Expected result:

The image resolution should change (to a lower quality with thumbnail, higher quality with large or full).

Screenshots

Types of changes

On mobile, the name property in imageSizes is undefined, but label is already set. So this PR defaults to using the label if it is truthy, and falls back to using the name if not.

To test:

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 20892. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[peril-wordpress-mobile]

	Warnings
⚠️	PR is missing at least one label.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

[mkevins]

Closing this: the label fix will target develop on gutenberg-mobile, and not a release branch.