Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
gutenberg
: WordPress/gutenberg#19800gutenberg-mobile
: wordpress-mobile/gutenberg-mobile#1798WordPress-iOS
: wordpress-mobile/WordPress-iOS#13257Description
This PR fixes the image size option labels in the gallery block settings. The image size options were added for web, but on mobile, the labels were undefined. This resulted in "blank" buttons.
How has this been tested?
Tested on Android via WordPress-Android, and iOS via WordPress-iOS:
Steps:
Expected result:
Steps:
Expected result:
The image resolution should change (to a lower quality with thumbnail, higher quality with large or full).
Types of changes
On mobile, the
name
property in imageSizes is undefined, butlabel
is already set. So this PR defaults to using thelabel
if it is truthy, and falls back to using thename
if not.PR submission checklist:
RELEASE-NOTES.txt
if necessary.