Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stats Refresh] Fix period displayed on date bar #11756

Merged
merged 1 commit into from
May 22, 2019

Conversation

ScoutHarris
Copy link
Contributor

Fixes #11755

This reinstates the correct period displayed on the date bar. It broke with this change, which I believe was just a copy/paste error. I've checked out the charts, and they look fine. But please give them a look to be sure.

To test:

  • Go to Stats.
  • Select Day, Week, Month, Year.
  • Verify the period displayed on the date bar once again reflects the period selected.

days

weeks

months

years

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@ScoutHarris ScoutHarris added this to the 12.6 milestone May 22, 2019
@ScoutHarris ScoutHarris requested a review from a user May 22, 2019 22:08
@ScoutHarris ScoutHarris self-assigned this May 22, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 22, 2019
45 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScoutHarris you're right - this was a copy-paste error from PostStatsTableViewController on the commit you referenced. Nicely spotted!

This change is working as expected. Thank you!

:shipit:

@ScoutHarris ScoutHarris merged commit 70ee853 into develop May 22, 2019
@ScoutHarris ScoutHarris deleted the fix/11755-date_bar_displayed_date branch May 22, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stats Refresh] Date bar now only shows the current day
1 participant