Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update the targetSdk version to 34 from 33. #141

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

notandyvee
Copy link
Contributor

Issue: #140
Parent: https://github.com/orgs/wordpress-mobile/projects/223

Updates targetSdk to 34 (Android 14)

  • Checkout this branch
  • Use this branch through Wordpress Android (uncomment localWPUtilsPath in local-builds.gradle file at the root of app)
  • Try out various flows and ensure there are no regressions.

@notandyvee notandyvee added the Android 14 Updates to comply with Android 14 changes. label Jan 19, 2024
@ravishanker
Copy link
Contributor

ravishanker commented Jan 22, 2024

👋 @notandyvee - Since utils is used in WordPress-Android main. Please also create a branch on WordPress-Android, and update this branch build # 141-e3b4df5b0e54124184d8bb89682e80edc8ec0f0b in build.gradle file in that branch. Then we can test it from WordPress-Android branch for any side effects.

Once this utils branch gets merged after this PR is approved, then publish a new release version of Utils lib, and update it in the build.gradle file of WordPress-Android branch before merging it to its trunk.

Copy link
Contributor

@ravishanker ravishanker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Draft a new release after merging. Update it on WordPress-Android branch wordpress-mobile/WordPress-Android#19999

@notandyvee notandyvee merged commit 4e85ad5 into trunk Jan 24, 2024
8 checks passed
@notandyvee notandyvee deleted the fix/target-sdk-34-update branch January 24, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 14 Updates to comply with Android 14 changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants