[Fix] Update targetSdk to 34 from 33. #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there are build issues. Will fix. |
|
I tested and confirmed targetSdk upgrade works. 👍🏻 |
5 tasks
|
Done @irfano . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Issue: #1072
Related: wordpress-mobile/gutenberg-mobile#6533.
This PR bumps the
targetSdkversion from 33 to 34. It depends on WP Utils 141: wordpress-mobile/WordPress-Utils-Android#141Test
Review
@irfano
Note
I'm not 100% sure how to test this against WP-util, other than waiting until that one is merged and then updating it here. Thoughts @ravishanker
Make sure strings will be translated:
strings.xmlas a part of the integration PR.