-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GutenbergKit #21223
base: trunk
Are you sure you want to change the base?
Add GutenbergKit #21223
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #21223 +/- ##
===========================================
+ Coverage 40.46% 82.51% +42.05%
===========================================
Files 1530 15 -1515
Lines 69826 532 -69294
Branches 11443 50 -11393
===========================================
- Hits 28255 439 -27816
+ Misses 39124 75 -39049
+ Partials 2447 18 -2429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… this functionality is added
Found 1 violations: The PR caused some dependency changes (expand to see details)
++--- project :libs:editor
+| \--- org.wordpress.gutenbergkit:android:23-7f3f9409de9531d7ed8d69e63365dd7dfe9bafcd
+| +--- androidx.core:core-ktx:1.13.1 (*)
+| +--- androidx.appcompat:appcompat:1.7.0 (*)
+| +--- com.google.android.material:material:1.12.0 (*)
+| +--- androidx.webkit:webkit:1.11.0 -> 1.12.0 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.0 -> 1.9.10 (*)
+\--- org.wordpress.gutenbergkit:android:23-7f3f9409de9531d7ed8d69e63365dd7dfe9bafcd (*)
Please review and act accordingly
|
Quality Gate passedIssues Measures |
Related PRs:
This PR adds GutenbergKit behind a feature flag. Due to the complexity of the editor setup in the app, I incorporated the new code into existing files, which made it difficult to work with the mixed Java and Kotlin files.
Most of the editor's functionality should be working, although I disabled some UI elements, such as the undo/redo buttons and certain menu items, until we add support for them.
Current feature support:
To Test:
Note
Precondition: Enable the feature flag, Go to the Me tab > Debug settings >
experimental_block_editor
Testing cases
Creating an empty post
Editing an existing post
Create an empty page
Create a page from a layout
Blogging prompts
Sharing a site
Media upload
Smoke test the current editor
To make sure no regressions were added, smoke testing the current editor would be great, adding some texts and media to make sure it works as expected.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):