-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Android - Add initial Editor params #23
Open
geriux
wants to merge
31
commits into
trunk
Choose a base branch
from
feature/add-android-api-settings
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+320
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
geriux
commented
Sep 13, 2024
geriux
commented
Sep 13, 2024
geriux
force-pushed
the
feature/add-android-api-settings
branch
from
September 17, 2024 15:45
21bc472
to
033a117
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
This PR adds the initial editor parameters for Android, following the approach we used on iOS.
It enables the
domStorageEnabled
feature for the WebView, allowing the use of thelocalStorage
API.Unfortunately, on Android, there is nothing similar to iOS's
addUserScript
to inject the editor's configuration. Therefore, we inject the configuration as soon as we receive the first request from the WebView. In this case, it happens when theindex.html
file is requested, triggering a call togetEditorConfiguration
to inject the configuration.To test
Note
Use the following WordPress Android build.
All testing instructions are in the PR linked above.