Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Android - Add initial Editor params #23

Open
wants to merge 31 commits into
base: trunk
Choose a base branch
from

Conversation

geriux
Copy link
Member

@geriux geriux commented Sep 10, 2024

Related PRs:

This PR adds the initial editor parameters for Android, following the approach we used on iOS.

It enables the domStorageEnabled feature for the WebView, allowing the use of the localStorage API.

Unfortunately, on Android, there is nothing similar to iOS's addUserScript to inject the editor's configuration. Therefore, we inject the configuration as soon as we receive the first request from the WebView. In this case, it happens when the index.html file is requested, triggering a call to getEditorConfiguration to inject the configuration.

To test

Note

Use the following WordPress Android build.
All testing instructions are in the PR linked above.

@geriux geriux force-pushed the feature/add-android-api-settings branch from 21bc472 to 033a117 Compare September 17, 2024 15:45
@geriux geriux marked this pull request as ready for review September 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant