Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment - Gutenberg Android X migration #10020

Merged
merged 54 commits into from
Jul 10, 2019

Conversation

marecar3
Copy link
Contributor

@marecar3 marecar3 commented Jun 10, 2019

Updates the Gutenberg mobile ref to point to the latest work, including the effort to migrate to AndroidX.

Gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1112

To test:

  • Build and run WPAndroid and check that the block editor is working as normal.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 10, 2019

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

…x_build

Gutenberg/Android X: Apply Java 1.8 compileOptions even when building from binaries
@daniloercoli
Copy link
Contributor

Tested this PR and LGTM! I was able to build both from local src, and remote artifacts.

Let me know @marecar3 if other tests are needed, I just see we're using RN 0.6.0-RC1, but i guess it's safe to use it for the moment, otherwise we can't move forward our prjs.

@marecar3
Copy link
Contributor Author

Thanks @daniloercoli !

@marecar3
Copy link
Contributor Author

I was also able to build both from local src, and remote artifacts.
It seems that we are ready :)

@hypest
Copy link
Contributor

hypest commented Jun 19, 2019

With v0.60 being a RC still, let's just test it out even more, ideally on the iOS side too, and look out for points of interest from the changelog that we might need to test.

It feels like the 0.60 release is not far although it will probably miss our code-freeze Monday so, yeah, let's test it out and we will probably merge before the 0.60 gets promoted to full release.

@hypest hypest added this to the 12.9 milestone Jul 10, 2019
@hypest
Copy link
Contributor

hypest commented Jul 10, 2019

Will retarget this PR to the gb/release-1.9.0 branch, to include it in the gutenberg-mobile release.

@hypest hypest changed the base branch from develop to gb/release-1.9.0 July 10, 2019 11:00
Copy link
Contributor

@daniloercoli daniloercoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested after latest changes on the Analytics side for the unsupported blocks list and works as expected.

@daniloercoli
Copy link
Contributor

Just noticed on a clean installation of the app - building the app with GB-src-code-mode set to OFF - WPAndroid hash c63e1e7, gutenberg-mobile hash 4107bf6e - that it doesn't show the Video block.
Nor in the inserter, nor in the editor if you load a post with a video block (the default unsupported block placeholder is then shown).

@marecar3 marecar3 merged commit 83a3e58 into gb/release-1.9.0 Jul 10, 2019
@marecar3 marecar3 deleted the gutenberg/android_x_migration branch July 10, 2019 18:40
@hypest
Copy link
Contributor

hypest commented Jul 11, 2019

Just noticed on a clean installation of the app - building the app with GB-src-code-mode set to OFF - WPAndroid hash c63e1e7, gutenberg-mobile hash 4107bf6e - that it doesn't show the Video block.

Indeed, as @marecar3 has found out, we disabled the block in the v1.8 editor release so it stayed disabled in here too because we've updated from develop. Decided to just revert the release-notes.txt changes in this PR and enable the block in the v1.9 release PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants