Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

0.60.x Discussion #116

Closed
grabbou opened this issue Apr 17, 2019 · 123 comments
Closed

0.60.x Discussion #116

grabbou opened this issue Apr 17, 2019 · 123 comments
Labels
pre-release rc Release candidate release status Information about an upcoming or ongoing release

Comments

@grabbou
Copy link
Member

grabbou commented Apr 17, 2019

0.60.0-rc.0 is most likely going to be released tomorrow. The branch is already cut. We are working on the changelog.

Stay tuned.

@grabbou grabbou added pre-release rc Release candidate release status Information about an upcoming or ongoing release labels Apr 17, 2019
@react-native-community react-native-community locked as too heated and limited conversation to collaborators Apr 17, 2019
@react-native-community react-native-community unlocked this conversation Apr 18, 2019
@radeno
Copy link

radeno commented Apr 18, 2019

@grabbou I think better timing for cut first RC should be next week. Easter holidays are behind door and many developers will not work. Even first RC-0 will be as fresh as possible next week.

@rhdeck
Copy link

rhdeck commented Apr 19, 2019

Was the delay monday decided? Or is the drop happening today (Friday)? Looking to test the hot new autolinking.

@turnrye
Copy link
Member

turnrye commented Apr 20, 2019

@rhdeck yes, we're delaying the publish til Monday. We'll have a WIP changelog today, though it'll still need a lot of refinement.

@grabbou
Copy link
Member Author

grabbou commented Apr 20, 2019

Yes. The release is ready to go and tests are passing. I wanted to wait for the changelog because the amount of changes is quite big and we want to wrap it up on the CLI side too.

@Vyazovoy
Copy link

Any chances it will be published this week?

@piashcse
Copy link

piashcse commented Apr 26, 2019

is there any possibility to release 0.60-rc.0 by next week?

@grabbou
Copy link
Member Author

grabbou commented Apr 28, 2019 via email

@grabbou
Copy link
Member Author

grabbou commented Apr 30, 2019

0.60 is currently blocked due to CocoaPods integration. We have recently migrated default template to CocoaPods but want to avoid users running pod install after react-native init.

Our work can be tracked here: facebook/react-native#24638, tho we are hitting blocker after blocker.

Heading off to holidays, will be back on Monday and that's most likely when I resume my work on the CLI where additional support has to be added.

@jeveloper
Copy link

Hope you have a great holiday man , good for you @grabbou

@Salakar
Copy link
Member

Salakar commented May 3, 2019

Any chance we could cherry pick these two small commits:

@mikehardy
Copy link

@Salakar - I don't think 0.60 is cut yet, so that comment might best be on 0.59.x for cherry pick?

@sunnylqm
Copy link
Contributor

sunnylqm commented May 4, 2019

@mikehardy Already cut and was planned to publish last week https://github.com/facebook/react-native/commits/0.60-stable

@grabbou
Copy link
Member Author

grabbou commented May 6, 2019

Yes. I can include them too once we are done with the CocoaPods issue.

Update: Unfortunately, the approach in facebook/react-native#24638 ended up being a dead end. We will be running pod install on the client side (meaning you need to have CocoaPods pre-installed).

We are going to implement this ticket react-native-community/cli#368 and we will ship 0.60 as soon as it's resolved.

Unfortunately, given the amount of things to coordinate for 0.60, I can't give you any promises. I will try to do my best to ship it as soon as possible tho.

@jsamr
Copy link

jsamr commented May 7, 2019

Please cherry-pick facebook/react-native@c5c79e5 which prevent a memory leak on iOS!

EDIT Apparently, there is a header issue after having been merged. It's being fixed

@jsamr
Copy link

jsamr commented May 8, 2019

And it would be marvelous if we had font family support in Android, which has just been merged into master facebook/react-native@fd6386a. This PR makes Android xml font declarations operable within the React Native framework.

Basically, it means that you can have mixed nested font styles for custom fonts (fontFamily, fontStyle and fontWeight) without the need to use postscript font name such as OpenSans-Bold). An example is provided in the commit if you want to know how to achieve that.

@danilobuerger
Copy link

danilobuerger commented May 10, 2019

Is 0.60 going to be recut? If not, please cherry pick

(This was already requested for 0.59.5, but couldn't be cherry picked because of a dependent commit)

This fixes quite a few crashes when using LayoutAnimations, so its definitely worth picking in my opinion.

@radeno
Copy link

radeno commented May 10, 2019

I agree with @danilobuerger about recutting new RC0. 22 days from first recut is long time. Many fine bugfixes and some new improvements are very promising to have in first release candidate. But i don't know how much time it takes and how much new problems and issues will appear after merging commits.

@jinshin1013
Copy link

Can we also cherry pick this if it's not too late?:

@grabbou
Copy link
Member Author

grabbou commented May 14, 2019

We will look into re-cutting 0.60 before making the first release. Depending on the tests and stability, we may or may not do it.

I will update you in this issue. Meanwhile, please wait a bit with suggesting cherry-picks until you give the first release a go.

@rhdeck
Copy link

rhdeck commented May 14, 2019

Is there a new timeframe? We're four weeks past "most likely going to be released tomorrow." We all know things take time, but would help my dev efforts to have a rough undertstanding of when this would be pre-release, but on npm.

@kelset
Copy link
Member

kelset commented Jun 19, 2019

Ok quick update: I've managed to cherry pick

and

The other two commits:

were already in the branch.

Which leads me two a good news and a bad news:

  • my test with these cherry-picks went ✅
  • the issue with the scheduler version is not actually fixed, and we are talking with the FB engineers to come up with a solution. But it's likely that it will need to use a yarn resolution in the package.json.

I will not release the RC2 until I know what we will do about the scheduler thing, I'll update here asap.

kelset pushed a commit to facebook/react-native that referenced this issue Jun 20, 2019
Summary: Fixes react-native-community/releases#116 (comment)

Reviewed By: gaearon

Differential Revision: D15901557

fbshipit-source-id: 653119c181585cf9a4a561b350c66bd10cb674bd
@kelset
Copy link
Member

kelset commented Jun 20, 2019

Hey everyone! Thanks to the help of @rickhanlonii we found a solution for the scheduler for RC2, and now RC2 is out 🚀

This will likely be the last RC before 0.60.0, unless something huge bubbles up. So please, test it and let us know if you have any regressions 🤗

(as always, please open an issue in the main repo & just post here a link so that we can keep track of the conversation more easily!)


EDIT: nope just got some news on a feature that we want to add to 0.60, we'll do another RC next week just to be safe 😇

@robertying

This comment has been minimized.

@JonnyBurger

This comment has been minimized.

@mikehardy
Copy link

@kelset thanks for the patience on the regression @robertying found (and fixed) 💪 when this PR lands it fixes things facebook/react-native#25363

@kelset
Copy link
Member

kelset commented Jun 24, 2019

Hey everyone, it seems that that extra feature will not land in the end.

But since we have a few Android commits that needs to be cherry picked:

I'll probably still do a RC3 first this week.


EDIT: it seems that there is an issue with pods facebook/react-native#25349 so I'll wait to get more feedback on that before doing the RC

@doublex
Copy link

doublex commented Jun 24, 2019

Could you apply facebook/react-native@690e85d in 0.60?

@kelset
Copy link
Member

kelset commented Jun 25, 2019

Hey everyone - quick update. By end of this week I'm expecting a couple of PRs to land that we want to cherry pick:

  • a bump to the CLI to rc3
  • an update for the JSC which should solve most of the issues related to Android 64b builds

And there is a small chance that we'll have a fix for the use_frameworks! pod config.
We'll do a RC3 when those two commits land, and likely 0.60.0 will be the release after.

@muditpant13

This comment has been minimized.

@lucaspereirasouzat

This comment has been minimized.

@nicoburns

This comment has been minimized.

@kelset
Copy link
Member

kelset commented Jun 28, 2019

Hey everyone 👋

I just finished cherry picking + testing the commits above, plus the ones described (bump to CLI RC & JSC for Android) - it should be rolling out any minute now.

For the iOS use_framework! issue there is a PR in the work but it will likely not be ready in time when we want to release 0.60.0.

In the meantime, please test RC3 and report if you are seeing any massive issues via opening an issue in the main repo & posting the link here!

@Kennytian

This comment has been minimized.

@thymikee

This comment has been minimized.

@Kennytian

This comment has been minimized.

@brunolemos
Copy link
Contributor

brunolemos commented Jun 29, 2019

ItemSeparatorComponent fix to cherry pick: facebook/react-native@1e42809

@thymikee
Copy link
Member

thymikee commented Jul 1, 2019

Include react-native.config.js in publish list: facebook/react-native@44c05da

@RoJoHub
Copy link

RoJoHub commented Jul 2, 2019

Could you apply facebook/react-native@fb550e9

@auchaphon
Copy link

Include facebook/react-native@76c50c1 Please

@kelset
Copy link
Member

kelset commented Jul 3, 2019

👋 everyone!

Thanks for the latest feedback, I just pushed the commit to trigger the release for 0.60.0 - let's close this and see you in the cherry pick request issue -> #130

@cbpanchal
Copy link

cbpanchal commented Aug 7, 2019

@grabbou Please check, react-native version 0.60.4 run android stuck and it takes too much time to compile. help me to short out this
npx__Users_chirag_Workspace_Upgrade_App_CrushClient_and_PreviewItem_js_—_CrushClient

Thanks

M-i-k-e-l pushed a commit to M-i-k-e-l/react-native that referenced this issue Mar 10, 2020
Summary: Fixes react-native-community/releases#116 (comment)

Reviewed By: gaearon

Differential Revision: D15901557

fbshipit-source-id: 653119c181585cf9a4a561b350c66bd10cb674bd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pre-release rc Release candidate release status Information about an upcoming or ongoing release
Projects
None yet
Development

No branches or pull requests