Skip to content

Commit

Permalink
Removed autoresizing mask for modal host container view (#25150)
Browse files Browse the repository at this point in the history
Summary:
Fixes #18177 . Related #24497. Autoresizing mask would conflict with `AutoLayout`. For example , it would impact `SafeAreaView`. And actually we don't need to use autoresizing mask,  we observe the bounds change notification and [update the frame manually](https://github.com/facebook/react-native/blob/1151c096dab17e5d9a6ac05b61aacecd4305f3db/React/Views/RCTModalHostView.m#L59).

## Changelog

[iOS] [Fixed] - Removed autoresizing mask for modal host container view
Pull Request resolved: #25150

Differential Revision: D15645148

Pulled By: cpojer

fbshipit-source-id: 95d5f40feaa980b959a3de6e273dccac8158c57b
  • Loading branch information
zhongwuzw authored and facebook-github-bot committed Jun 5, 2019
1 parent 69d1ed7 commit 2dd7dd8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions React/Views/RCTModalHostView.m
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,6 @@ - (void)insertReactSubview:(UIView *)subview atIndex:(NSInteger)atIndex
[subview addGestureRecognizer:_menuButtonGestureRecognizer];
}
#endif
subview.autoresizingMask = UIViewAutoresizingFlexibleHeight |
UIViewAutoresizingFlexibleWidth;

[_modalViewController.view insertSubview:subview atIndex:0];
_reactSubview = subview;
Expand Down

0 comments on commit 2dd7dd8

Please sign in to comment.