Skip to content
This repository has been archived by the owner on Dec 5, 2024. It is now read-only.

Rework project to work with dotnet only, use atlas-dotnet as backend #51

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Joaquimmnetto
Copy link
Collaborator

@Joaquimmnetto Joaquimmnetto commented Apr 17, 2024

Description

Big breaking update, most important changes include:

  • Removed support for mono as SonarScanner runner

  • Included support for dotnet as SonarScanner runner

  • No more standalone windows SonarScanner. Must also use dotnet as a runner

  • dotnet to be used as SonarScanner runner can be set through the sonarScanner.dotnetExecutable property

  • Installs by default sonarscanner-netcoreapp2.0, latest 5.x version (net45 compatible)

  • Removed support for builds with msBuild, now only builds with dotnet. Defaults to same dotnet executable as the one used to run SonarScanner.

  • Removed solutionMSBuild task

  • sonarScannerEnd no longer depends on sonarScannerBegin

  • Updated plugin structure and default to be more similar to modern atlas plugins

  • Added environment/properties input through DotnetSonarqubePluginConventions class

  • Execution doesn't depend anymore on an externally exposed SonarScanner object

  • All SonarScanner and Build related tasks now extends DotnetTask and with it the gradle-commons framework for executables. DOES NOT applies net.wooga.dotnet, uses it as a library.

Changes

  • CHANGE Uses dotnet instead of mono as SonarScanner runner

  • CHANGE dotnet as a runner now applies to Windows runs as well

  • ADD sonarScanner.dotnetExecutable property to set dotnet runner

  • CHANGE now by default installs .Net Core 2.0 variant of SonarScanner (5.x), required by dotnet runner

  • REMOVE Support for builds with MSBuild.exe

  • REMOVE solutionMSBuild task

  • CHANGE sonarScannerEnd no longer depends on sonarScannerBegin

  • REMOVE msBuildExecutable, dotnetExecutable and buildTool properties from BuildSolution and sonarScanner extension where applicable.

  • IMPROVECHANGE Updated plugin structure and default to be more similar to modern atlas plugins

  • ADD Several environment/properties input through DotnetSonarqubePluginConventions class

  • REMOVE sonarScanner.sonarScanner property

  • CHANGE SonarScannerBegin, SonarScannerEnd and BuildSolution now are based on DotnetTask from net.wooga.gradle:dotnet.

...

@Joaquimmnetto Joaquimmnetto force-pushed the change/use-atlas-dotnet-backend branch from a224c4a to da03cb2 Compare April 17, 2024 14:11
Copy link

apiiro bot commented Apr 17, 2024

WORKFLOW-9 · Comment on PR with Gray License

Remediation actions:
Legal Notice - Gray License ©️

The pull-request is adding an OSS library with a "Gray" license. This might indicate on a violation of our legal policy.
Please review our legal policy and make sure that you are following the rules under the "Gray components – Non - Distribution" section.

Other

  • ⚠ New license with dependency LGPL-3.0 ()
    • ⚠ Dependency org.sonarsource.scanner.gradle:sonarqube-gradle-plugin

Repository: atlas-dotnet-sonarqube
Applications: Wooga

View in Apiiro

@Joaquimmnetto Joaquimmnetto force-pushed the change/use-atlas-dotnet-backend branch from da03cb2 to f759f49 Compare April 17, 2024 14:11
@Joaquimmnetto Joaquimmnetto force-pushed the change/use-atlas-dotnet-backend branch from f759f49 to 5446fe5 Compare April 17, 2024 14:14
@Joaquimmnetto Joaquimmnetto changed the base branch from master to release/2.x April 18, 2024 07:53
@Joaquimmnetto Joaquimmnetto merged commit a09b9ae into release/2.x Apr 18, 2024
5 of 6 checks passed
Joaquimmnetto added a commit that referenced this pull request Aug 6, 2024
* qol improvments and renames

* updated properties and extension for easier use, also added buildTools block to extension

* optimize imports

* remove unused methods from osops

* removes unused method from SonarScannerFactory

* project rewrote to use dotnet/netcore as base, mono support dropped (#51)

* Add net.wooga.unity-sonarqube plugin (#52)

* initial implementation for wooga.gradle.unity-sonarqube

* adds windows dotnet installer

* update gradle to 7.6.4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant