Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate go-client from swagger #2691

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Generate go-client from swagger #2691

wants to merge 10 commits into from

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Nov 1, 2023 •
edited
Loading

closes #3053

Creates a new go api client automatically out of the swagger definition

@anbraten anbraten added breaking will break existing installations if no manual action happens enhancement improve existing features labels Nov 1, 2023
@qwerty287 qwerty287 mentioned this pull request Nov 1, 2023
Merged
@runephilosof-karnovgroup
Copy link
Contributor

Won't this type int or 'latest' be a problem?
https://github.com/woodpecker-ci/woodpecker/blob/main/server/api/pipeline.go#L126

Should it be changed to something like?

//	@Param		number		path	int|string		true	"the number of the pipeline, OR 'latest'"

@runephilosof-karnovgroup
Copy link
Contributor

The current client does takes int instead of int64 as arguments for repo_id and pipeline number etc.
It should take int64, how will this generated client know to take int64 arguments?

@qwerty287
Copy link
Contributor

@anbraten Can we close this and convert to an issue instead? There hasn't really been any work

@anbraten anbraten closed this Dec 28, 2023
@qwerty287 qwerty287 mentioned this pull request Dec 28, 2023
Open
4 tasks
@anbraten anbraten changed the title Generate swagger client Generate go-client from swagger Jun 3, 2024
@anbraten anbraten reopened this Jun 3, 2024
@anbraten anbraten removed the breaking will break existing installations if no manual action happens label Jun 3, 2024
@anbraten anbraten added this to the 3.0.0 milestone Jul 25, 2024
@qwerty287 qwerty287 added the breaking will break existing installations if no manual action happens label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens enhancement improve existing features
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Generate sdk from swagger
3 participants
@anbraten @runephilosof-karnovgroup @qwerty287