Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate sdk from swagger #3053

Open
4 tasks done
qwerty287 opened this issue Dec 28, 2023 · 1 comment · May be fixed by #2691
Open
4 tasks done

Generate sdk from swagger #3053

qwerty287 opened this issue Dec 28, 2023 · 1 comment · May be fixed by #2691
Labels
blocked It's ready but something external is blocking it enhancement improve existing features lib about our woodpecker-go api lib refactor delete or replace old code

Comments

@qwerty287
Copy link
Contributor

qwerty287 commented Dec 28, 2023 •
edited by 6543
Loading

Clear and concise description of the problem

as of #2691

blocked by swaggo/swag#386 -> #3897

Suggested solution

auto-generate client from swagger docs so we don't have to do it manually

Alternative

No response

Additional context

No response

Validations

  • Checked that the feature isn't part of the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@qwerty287 qwerty287 added enhancement improve existing features refactor delete or replace old code blocked It's ready but something external is blocking it lib about our woodpecker-go api lib labels Dec 28, 2023
@lafriks
Copy link
Contributor

lafriks commented Jan 10, 2024

I don't think that's good idea.. I would still like to keep a better organized SDK than auto generated one, why even bother than if it can be generated by everyone who needs it. Generating structures would probably help but not the methods 1:1 imho

@anbraten anbraten linked a pull request Jul 13, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked It's ready but something external is blocking it enhancement improve existing features lib about our woodpecker-go api lib refactor delete or replace old code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generate go-client from swagger anbraten/woodpecker
2 participants
@lafriks @qwerty287