Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail on deprecated pipeline keys #2180

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Fail on deprecated pipeline keys #2180

merged 2 commits into from
Aug 9, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 9, 2023

so we can drop it in next minor version complete

@6543 6543 added the refactor delete or replace old code label Aug 9, 2023
@6543 6543 added this to the 1.1.0 milestone Aug 9, 2023
@6543 6543 added the enhancement improve existing features label Aug 9, 2023
@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Aug 9, 2023 •
edited
Loading

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-2180.surge.sh

@qwerty287 qwerty287 added breaking will break existing installations if no manual action happens pipeline-config related to pipeline config files (.yaml) labels Aug 9, 2023
@6543 6543 removed the enhancement improve existing features label Aug 9, 2023
@6543 6543 enabled auto-merge (squash) August 9, 2023 13:12
@6543 6543 disabled auto-merge August 9, 2023 13:24
@6543 6543 merged commit 71666f0 into woodpecker-ci:main Aug 9, 2023
@6543 6543 deleted the fail_hard_deprecated_pipeline_keys branch August 9, 2023 13:33
This was referenced Sep 8, 2023
Closed
Closed
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 5, 2023
Closed
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 15, 2023
Closed
qwerty287 added a commit to qwerty287/woodpecker that referenced this pull request Oct 31, 2023
@qwerty287
Revert "Fail hard on deprecated pipeline keys (woodpecker-ci#2180)"
7793a7b 
This reverts commit 71666f0.
@qwerty287 qwerty287 mentioned this pull request Oct 31, 2023
Merged
@anbraten anbraten changed the title fail hard on deprecated pipeline keys Fail hard on deprecated pipeline keys Nov 1, 2023
@anbraten anbraten changed the title Fail hard on deprecated pipeline keys Fail on deprecated pipeline keys Nov 1, 2023
@qwerty287 qwerty287 removed the breaking will break existing installations if no manual action happens label Nov 2, 2023
qwerty287 added a commit that referenced this pull request Nov 2, 2023
@qwerty287 @anbraten
Revert breaking pipeline changes (#2677)
c1faa95 
Revert #2180 and #2480 so we can release v2.0 without breaking changes
in pipeline config.

After merging #2476 we should apply these changes to a new v2.

After merging this, we should be ready for the 2.0 release.

---------

Co-authored-by: Anbraten <anton@ju60.de>
@qwerty287 qwerty287 added breaking will break existing installations if no manual action happens skip-changelog labels Nov 2, 2023
@anbraten anbraten mentioned this pull request Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten left review comments

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
breaking will break existing installations if no manual action happens pipeline-config related to pipeline config files (.yaml) refactor delete or replace old code skip-changelog
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @woodpecker-bot @anbraten @qwerty287