Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to check organization membership #1037

Merged
merged 8 commits into from
Jul 25, 2022

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Jul 19, 2022

Needed for right checks for organization wide methods

@lafriks lafriks changed the title Add remote method to check organization membership Add method to check organization membership Jul 19, 2022
@lafriks lafriks mentioned this pull request Jul 19, 2022
6 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #1037 (fc62a6d) into master (1e8d4cc) will decrease coverage by 0.83%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
- Coverage   51.27%   50.44%   -0.84%     
==========================================
  Files          81       81              
  Lines        6157     6249      +92     
==========================================
- Hits         3157     3152       -5     
- Misses       2817     2914      +97     
  Partials      183      183              
Impacted Files Coverage Δ
server/model/perm.go 0.00% <ø> (ø)
server/remote/bitbucket/bitbucket.go 86.87% <0.00%> (-2.43%) ⬇️
server/remote/bitbucketserver/bitbucketserver.go 0.00% <0.00%> (ø)
server/remote/coding/coding.go 63.84% <0.00%> (-0.92%) ⬇️
server/remote/gitea/gitea.go 35.38% <0.00%> (-1.86%) ⬇️
server/remote/github/github.go 15.71% <0.00%> (-0.31%) ⬇️
server/remote/gitlab/gitlab.go 24.31% <0.00%> (-2.64%) ⬇️
server/remote/gogs/gogs.go 52.73% <0.00%> (-3.65%) ⬇️
server/logging/log.go 48.83% <0.00%> (-5.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e8d4cc...fc62a6d. Read the comment docs.

server/remote/remote.go Outdated Show resolved Hide resolved
@anbraten
Copy link
Member

anbraten commented Jul 19, 2022

For caching I have created a separate issue as this could be interesting for the branches and permission calls: #1039

@lafriks lafriks marked this pull request as ready for review July 19, 2022 21:02
@6543 6543 added this to the 1.0.0 milestone Jul 19, 2022
@6543 6543 added the feature add new functionality label Jul 19, 2022
@lafriks
Copy link
Contributor Author

lafriks commented Jul 23, 2022

I don't think CI failure is related to this PR as there is no changes related to database or datasource module

server/remote/remote.go Outdated Show resolved Hide resolved
server/cache/membership.go Outdated Show resolved Hide resolved
server/cache/membership.go Outdated Show resolved Hide resolved
server/cache/membership.go Outdated Show resolved Hide resolved
server/cache/membership.go Outdated Show resolved Hide resolved
@lafriks
Copy link
Contributor Author

lafriks commented Jul 24, 2022

@anbraten refactored remote method to return struct and simplified membership service

@6543 6543 merged commit 19dfc33 into woodpecker-ci:master Jul 25, 2022
@lafriks lafriks deleted the feat/org_member_check branch July 25, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants