Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global and organization secrets #1027

Merged
merged 6 commits into from
Aug 14, 2022
Merged

Global and organization secrets #1027

merged 6 commits into from
Aug 14, 2022

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Jul 17, 2022 •
edited
Loading

Adds way to add server wide and organization wide secrets

Organization page

attels

Organization settings page

attels

Global settings page

attels

@6543 6543 added the feature add new functionality label Jul 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022 •
edited
Loading

Codecov Report

Merging #1027 (36f5962) into master (bed3ef1) will increase coverage by 0.14%.
The diff coverage is 58.33%.

❗ Current head 36f5962 differs from pull request most recent head 7a12440. Consider uploading reports for the commit 7a12440 to get more accurate results

@@            Coverage Diff             @@
##           master    #1027      +/-   ##
==========================================
+ Coverage   50.51%   50.65%   +0.14%     
==========================================
  Files          82       83       +1     
  Lines        6270     6341      +71     
==========================================
+ Hits         3167     3212      +45     
- Misses       2920     2943      +23     
- Partials      183      186       +3
Impacted Files Coverage Δ
server/model/secret.go 54.34% <0.00%> (-6.63%) ⬇️
server/store/datastore/migration/migration.go 37.50% <ø> (ø)
.../store/datastore/migration/006_secrets_add_user.go 30.76% <30.76%> (ø)
server/store/datastore/migration/common.go 37.50% <46.66%> (+1.61%) ⬆️
server/store/datastore/secret.go 100.00% <100.00%> (ø)
server/remote/gitlab/gitlab.go 24.31% <0.00%> (-0.06%) ⬇️
server/logging/log.go 54.65% <0.00%> (+5.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@6543 6543 added this to the 1.0.0 milestone Jul 17, 2022
@lafriks lafriks force-pushed the feat/global_org_secrets branch 2 times, most recently from 24b3524 to 6b75e20 Compare July 25, 2022 09:47
@lafriks lafriks marked this pull request as ready for review July 25, 2022 09:47
anbraten
anbraten reviewed Jul 28, 2022
View reviewed changes
server/store/datastore/migration/common.go Show resolved Hide resolved
server/store/datastore/migration/common.go Show resolved Hide resolved
server/store/datastore/secret.go Outdated Show resolved Hide resolved
server/model/secret.go Show resolved Hide resolved
web/src/assets/locales/en.json Outdated Show resolved Hide resolved
web/src/components/secrets/SecretList.vue Show resolved Hide resolved
web/src/components/admin/settings/AdminSecretsTab.vue Show resolved Hide resolved
web/src/router.ts Show resolved Hide resolved
web/src/router.ts Show resolved Hide resolved
web/src/assets/locales/en.json Show resolved Hide resolved
@lafriks
Copy link
Contributor Author

lafriks commented Jul 30, 2022

@anbraten added suggested changes

@qwerty287 qwerty287 mentioned this pull request Aug 2, 2022
Closed
@lafriks
Implement database changes and store methods for global and organizat…
79e9c2b 
…ion secrets

* Add tests for new store methods
* Add organization secret API and UI
* Add global secrets API and UI
@lafriks
Add suggestions
f0762b1
@lafriks
Update warning style
36f5962
anbraten
anbraten approved these changes Aug 14, 2022
View reviewed changes
server/api/global_secret.go Outdated Show resolved Hide resolved
server/api/global_secret.go Outdated Show resolved Hide resolved
server/api/global_secret.go Outdated Show resolved Hide resolved
server/api/org_secret.go Outdated Show resolved Hide resolved
server/api/org_secret.go Outdated Show resolved Hide resolved
server/api/org_secret.go Outdated Show resolved Hide resolved
@anbraten
Copy link
Member

@lafriks https://ci.woodpecker-ci.org/woodpecker-ci/woodpecker/build/3121/41

@lafriks
Copy link
Contributor Author

lafriks commented Aug 14, 2022

@anbraten fixed

@anbraten anbraten enabled auto-merge (squash) August 14, 2022 11:30
@anbraten anbraten disabled auto-merge August 14, 2022 11:30
@anbraten anbraten enabled auto-merge (squash) August 14, 2022 11:30
@anbraten anbraten merged commit 1ac2c42 into woodpecker-ci:master Aug 14, 2022
@lafriks lafriks deleted the feat/global_org_secrets branch August 14, 2022 11:49
@anbraten anbraten mentioned this pull request Aug 14, 2022
Closed
@lafriks lafriks mentioned this pull request Aug 15, 2022
Merged
@6543 6543 mentioned this pull request Aug 27, 2022
Merged
@anbraten anbraten mentioned this pull request Sep 3, 2022
Closed
3 tasks
@6543 6543 mentioned this pull request Jan 14, 2023
Merged
lafriks pushed a commit that referenced this pull request Jan 14, 2023
@6543
use same sql for set default statement on mysql/mariadb and postgres (#…
c276bc8 
…1540)

introduced by #1027 so it does not need a changelog or backport
@JakobDev JakobDev mentioned this pull request May 5, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 left review comments

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
feature add new functionality
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-commenter @anbraten @qwerty287 @6543