Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task log output colors have numbering also colored #998

Closed
4 tasks done
lafriks opened this issue Jun 21, 2022 · 1 comment · Fixed by #1067
Closed
4 tasks done

Task log output colors have numbering also colored #998

lafriks opened this issue Jun 21, 2022 · 1 comment · Fixed by #1067
Labels
bug Something isn't working ui frontend related

Comments

@lafriks
Copy link
Contributor

lafriks commented Jun 21, 2022

Component

web-ui

Describe the bug

Line numbers are also colored if log output has term colors.

attels

System Info

21534252303b8def38905e0b56e3a0faed5c71c4

Additional context

No response

Validations
@qwerty287 qwerty287 added bug Something isn't working ui frontend related and removed pending:bug labels Jun 29, 2022
@qwerty287
Copy link
Contributor

This is an issue with the xterm.js "hack" we use to could numbers.

@qwerty287 qwerty287 mentioned this issue Jul 19, 2022
Closed
4 tasks
@lafriks lafriks mentioned this issue Aug 3, 2022
Merged
@6543 6543 closed this as completed in #1067 Aug 8, 2022
6543 pushed a commit that referenced this issue Aug 8, 2022
@lafriks @anbraten
Remove xterm and use ansi converter for logs (#1067)
2f5e5b8 
* Steaming works without flickering
* Text can be correctly copied
* Show only selected step output when streaming
* Improved exit code colors for better readability
* Adds time display on right side

When compiled assets/Build.js size was 355K, now it is 26K

Fixes #1012 
Fixes #998

Co-authored-by: Anbraten <anton@ju60.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove xterm and use ansi converter for logs lafriks-fork/woodpecker
2 participants
@lafriks @qwerty287