Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal issues #1012

Closed
4 tasks done
anbraten opened this issue Jul 5, 2022 · 3 comments · Fixed by #1067
Closed
4 tasks done

Terminal issues #1012

anbraten opened this issue Jul 5, 2022 · 3 comments · Fixed by #1067
Labels
bug Something isn't working ui frontend related

Comments

@anbraten
Copy link
Member

anbraten commented Jul 5, 2022

Component

web-ui

Describe the bug

I noticed some issues with the new terminal:

  • log lines for other running jobs shown in selected running jobs? 🤔 or the terminal is not properly reset after switching
  • space reserved for exit code x for running jobs (Screenshot 1)
  • exit code x pushed to bottom (only half of it visible) (Screenshot 2)
  • sometimes it still seems to flicker

Screenshot from 2022-07-05 09-28-45

Screenshot from 2022-07-05 09-27-57

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-3f73d5bf"}

Additional context

No response

Validations

@anbraten anbraten added pending:bug bug Something isn't working ui frontend related and removed pending:bug labels Jul 5, 2022
@qwerty287
Copy link
Contributor

I also noticed on mobile, if I click into the terminal area, my keyboard appears, but I can't type anything (obviously).

@thestr4ng3r
Copy link
Contributor

thestr4ng3r commented Jul 5, 2022

log lines for other running jobs shown in selected running jobs? 🤔 or the terminal is not properly reset after switching

I think this always happens while the job is still running, when it is streaming the log in realtime rather than just fetching it statically.

For our instance, we have switched to using xterm's dom renderer instead of the canvas-based one since the canvas one feels unresponsive to me when scrolling (always a bit delayed):
rizinorg@6146b70#diff-a381d47772869b92cbbfb7b65a6e4222af8629b6a0b5fd5ba7db7e12dd5bff4aR102
This generates a lot of dom, but might be worth trying out too.

@qwerty287
Copy link
Contributor

  1. The green Exit-Code 0 is not good visible in light mode.
  2. Also Task log output colors have numbering also colored #998

@6543 6543 closed this as completed in #1067 Aug 8, 2022
6543 pushed a commit that referenced this issue Aug 8, 2022
* Steaming works without flickering
* Text can be correctly copied
* Show only selected step output when streaming
* Improved exit code colors for better readability
* Adds time display on right side

When compiled assets/Build.js size was 355K, now it is 26K

Fixes #1012 
Fixes #998

Co-authored-by: Anbraten <anton@ju60.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui frontend related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants