This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update taxonomy templates so Legacy Template blocks don't take all available width #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
skip-changelog
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/5092-legacy-template-width-taxonomy-template
branch
from
8df43f7 to
e215742
Compare
frontdevde
reviewed
Nov 9, 2021
Co-authored-by: Michael P. Pfeiffer <frontdevde@users.noreply.github.com>
|
Thanks for reviewing @frontdevde! I updated this PR with your suggestions, so it's ready for another look. |
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
…ailable width (woocommerce#5105) * Update taxonomy templates so Legacy Template blocks don't take all available width * Add closing comments for Group block Co-authored-by: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Co-authored-by: Michael P. Pfeiffer <frontdevde@users.noreply.github.com>
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
…ailable width (woocommerce#5105) * Update taxonomy templates so Legacy Template blocks don't take all available width * Add closing comments for Group block Co-authored-by: Michael P. Pfeiffer <frontdevde@users.noreply.github.com> Co-authored-by: Michael P. Pfeiffer <frontdevde@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5092.
Same as #5093 but for taxonomy templates.
Screenshots
Before:
After:
Testing
/product-category/clothing/) and verify the templates no longer take all available width, but instead they are constrained to the theme width (see screenshots above)./product-tag/recommended/).