This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Update templates so Legacy Template blocks don't take all available width #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
type: bug
rubikuserbot
requested review from
a team and
frontdevde
and removed request for
a team
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
tjcafferkey
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
This LGTM and tests well. The failing tests look unrelated but feel free to rerun them, I can't see this change being responsible for them failing though.
On the themes I have been testing this on the content seems rather narrow but I guess like you mentioned this is down to the theme.
Aljullu
force-pushed
the
fix/5092-legacy-template-width
branch
from
60e777d to
22c17f6
Compare
Aljullu
changed the title
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 14, 2021
jonny-bull
pushed a commit
to jonny-bull/woocommerce-gutenberg-products-block
that referenced
this pull request
Dec 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5092.
This PR updates the templates as described in #5092 so the Legacy Template block is rendered inside a Group block with attribute
{"layout":{"inherit":true}}. That makes it so the block doesn't occupy the entire width.Screenshots
Before:
After:
Testing