-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ldd-check test to several packages #45433
Conversation
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: Based on the build error, I'll provide a detailed analysis and solution: • Detected Error:
• Error Category: Build Configuration/Dependency • Failure Point: Compiling starter/privileged_service_protocol.cc with clang-17 and libc++ • Root Cause Analysis: • Suggested Fix: environment:
contents:
packages:
# Add these entries
- libcxx-17-dev
- libcxx-17
- libcxxabi-17-dev
- libcxxabi-17 And modify the build flags in the bazel command: - runs: |
# Add these environment variables
export CXXFLAGS="-stdlib=libc++ -I/usr/include/c++/v1"
export LDFLAGS="-stdlib=libc++ -L/usr/lib"
bazel build --fission=no --config=clang \
--cxxopt="-stdlib=libc++" \
--cxxopt="-I/usr/include/c++/v1" \
--linkopt="-L/usr/lib" \
... # rest of the flags • Explanation:
• Additional Notes:
• References:
|
Signed-off-by: Brian Murray <brian.murray@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How willing would you be to wait for a ldd-check update that included chainguard-dev/tw#20 ?
If we have the ability to use ${{context.name}}
, then that means all of these:
- uses: test/tw/ldd-check
with:
packages: abseil-cpp
Turn into:
- uses: test/tw/ldd-check
It would require
- an included change
pipelines/test/tw/ldd-check.yaml
to use${{context.name}}
- support to be in all necessary places for ${{context.name}} use , which landed Add ${{context.name}} string substitution chainguard-dev/melange#1810
@dannf do you know if 1810 made it into all necesary places?
While I'm not in a hurry I've changes similar to this PR to 225 yaml files and would prefer not to have to redo the work. |
No description provided.