Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ${{context.name}} string substitution #1810

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

smoser
Copy link
Contributor

@smoser smoser commented Feb 24, 2025

Many of the places where subpkg.name is used now would be even nicer with a context-specific name.

Ie, we have this stanza in wolfi lots of times:

uses: test/ldd-check
with:
  packages: ${{subpkg.name}}

But if we changed the default in test/ldd-check to be 'context.name' then we could replace those with:

uses: test/ldd-check

Many of the places where subpkg.name is used now would be even
nicer with a context-specific name.

Ie, we have this stanza in wolfi lots of times:

    uses: test/ldd-check
    with:
      packages: ${{subpkg.name}}

But if we changed the default in test/ldd-check to be 'context.name'
then we could replace those with:

    uses: test/ldd-check
dannf
dannf previously approved these changes Feb 24, 2025
dannf
dannf previously approved these changes Feb 24, 2025
@dannf
Copy link
Contributor

dannf commented Feb 24, 2025

(approved for diagnoses purposes only)

@smoser
Copy link
Contributor Author

smoser commented Feb 24, 2025

Well,
commit c5cb1c9 failed "Ensure melange package is reproducible" here. with output:

sha256sum: WARNING: 1 of 1 computed checksums did NOT match
stage3/x86_64/melange-0.0.1-r0.apk: FAILED

But then when I tried to add some help diagnosing what went wrong in 33cb0e1 and dcdadcc the test passed. Log of the successful run is here. the output of the most recent run there is pretty clear success:

stage3/x86_64/melange-0.0.1-r0.apk: OK
PASS: stage2 == stage3 for stage2/x86_64/melange-0.0.1-r0.apk
048cf4111051ce4dbe19d753234655f55701ee06dc59409b6db4d1ea8ad3dd94  stage2/x86_64/melange-0.0.1-r0.apk
048cf4111051ce4dbe19d753234655f55701ee06dc59409b6db4d1ea8ad3dd94  stage3/x86_64/melange-0.0.1-r0.apk

So... I don't know why the one failed, but I would not think it was related to this change.

@dannf
Copy link
Contributor

dannf commented Feb 24, 2025

I support merging w/ the diagnostics until if/when we find out why that failed

@smoser smoser merged commit bc87697 into chainguard-dev:main Feb 24, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants