Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More fixes for building x86 in Visual Studio for non-windows OS #8098

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dgarske
Copy link
Contributor

@dgarske dgarske commented Oct 22, 2024

Description

More fixes for building x86 in Visual Studio for non-windows OS (Watcom C compiler). Followup to PR #7884. Fixes ZD 18465

  • Consolidate the USE_WINDOWS_API to a single place.
  • Expand the WOLFSSL_NOT_WINDOWS_API improvement for intrinsics and word sizes.
  • Fix for macro variadic ... when no variables are used (some compilers like Watcom C have issue with this).
  • Fix for Watcom C compiler "long long" -> "__int64".
  • Fix a couple of minor cast warnings reported from VS.

Testing

Worked with customer

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@dgarske dgarske self-assigned this Oct 22, 2024
@dgarske dgarske changed the title More fixes for building x86 in Visual Studio for non-windows OS. Foll… More fixes for building x86 in Visual Studio for non-windows OS Oct 22, 2024
@dgarske
Copy link
Contributor Author

dgarske commented Oct 23, 2024

Stage 'PRB-medium-runtime.txt_4'
--enable-all --enable-asn=template --enable-dtls-mtu 
FAIL: scripts/openssl.test

@dgarske
Copy link
Contributor Author

dgarske commented Oct 23, 2024

socat Tests:

FAILED: 146 216 309 310 326 386 399 402 459 460 467 468 478 492 528 530
FAILED unexpected: 326

…om C compiler). Followup to PR wolfSSL#7884. Fixes ZD 18465

* Consolidate the USE_WINDOWS_API to a single place.
* Expand the `WOLFSSL_NOT_WINDOWS_API` improvement for intrinsics and word sizes.
* Fix for macro variadic `...` when no variables are used (some compilers like Watcom C have issue with this).
* Fix for Watcom C compiler "long long" -> "__int64".
* Fix a couple of minor cast warnings reported from VS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants